Fy23 redesign #616
Fy23 redesign #616
Conversation
Added metadata, fixed header hierarchy, made header capitalization consistent, updated copy in anticipation of fy23-redesign.
Added metadata, updated header hierarchy, updated copy for fy23-redesign
Added metadescription, updated header hierarchy, updated copy for fy23-redesign
Added metadescription, updated header hierarchy, updated copy for fy23-redesign
Added metadescription, framing copy
Added metadescription, framing copy
Added metadescription, framing copy
Added metadescription, updated copy for fy23-redesign
There was a problem hiding this comment.
@cyndy-llnl - this looks great overall! Really thankful for your work here!
The biggest thing I want to hash out is the presence of the {% raw %}{% endraw %} blocks that you've added, why are those being added after all the links?
|
|
||
| If you’re new to GitHub and open source in general, figuring out how to get set up can be a challenge. You may want to read through the GitHub Help pages on [setting up and managing your GitHub profile](https://help.github.com/categories/setting-up-and-managing-your-github-profile/). | ||
| If you're new to GitHub and open source in general, figuring out how to get set up can be a challenge. You may want to read through the GitHub Help pages on [setting up and managing your GitHub profile](https://help.github.com/categories/setting-up-and-managing-your-github-profile/){% raw %}{% endraw %}. |
There was a problem hiding this comment.
what's the rationale for {% raw %}{% endraw %}. ?
There was a problem hiding this comment.
Note that I see this in many places (every link?), and don't understand why it's there.
| permalink: /about/faq/ | ||
| --- | ||
|
|
||
| ## {{ page.title }} |
There was a problem hiding this comment.
I'll need to fire this up locally and check it out, I seem to recall there being a reason for starting at H2 here in these files, but I can't quite remember.
Hi Ian! That's based on guidance from digital.gov around the handling of external links. The {% raw %}{% endraw %} adds an external link icon on dev.llnl.gov, but perhaps that isn't true for the Software site? I should also note: Some of these updates "won't make sense" until our dev has had the chance to get in and implement the design (coming soon!) stuff. We know what components we're building so I went ahead and prepped the copy accordingly, but the full thing won't be complete for a hot minute. |
Co-authored-by: Ian Lee <[email protected]>
Sounds good! Wasn't sure if you'd be up for having your email so readily accessible Co-authored-by: Ian Lee <[email protected]>
|
I will set aside some time very soon to review in detail locally |
pages/about/index.md
Outdated
| * [Visualization Software Stands the Test of Time](https://str.llnl.gov/2021-05/brugger) | ||
| <!-- END: Quicklinks boxes --> | ||
|
|
||
| ### 2020 LLNL Computing Virtual Expo Materials |
There was a problem hiding this comment.
@cyndy-llnl What do you think about removing "2020" from this heading so it doesn't seem so outdated? The assets from the Expo are fairly evergreen.
There was a problem hiding this comment.
@hauten That works! I'm a fan of including the date if something is "of a moment," but when it's evergreen, you'll entice more folks to use it when an older date is omitted.
One thing: Is that a change you're making or that you'd like me to make? Happy to participate however you prefer!
There was a problem hiding this comment.
@cyndy-llnl I made the change just now, thx
There was a problem hiding this comment.
@cyndy-llnl If by chance the changes go live before the end of August, I'd like to retain the temporary banner from the currently live home page. It advertises tutorials that end on Aug 31. After that date, we don't need it anymore. Markup for the banner is in 47f696a.
|
@cyndy-llnl and @IanLee1521 I'm finished reviewing. I have one question for Cyndy above, plus one note about the temporary tutorials advertisement on the currently live home page. I made two commits that Cyndy may want to review. No other changes from me. |
|
@hauten We made a note about the tutorial banner and will retain it if we're able to launch before 8/31. I think the commits look good (and they'll make even better sense once Doug gets ahold of the site). Thanks! |
|
Incorporated and confirmed as part of #647 |
Individual comments by file. In general, changes include:
-Addition of a metadescription
-Addition of framing copy (/visualization pages only)
-Reorganization of header hierarchy
-Copy updates for fy23-redesign