Skip to content

Commit

Permalink
Merge branch 'woptim/spack-develop-2024-04-21' into woptim/rocm-6-0-2
Browse files Browse the repository at this point in the history
  • Loading branch information
adrienbernede committed Apr 22, 2024
2 parents 32b5685 + 4635ce5 commit eee3272
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 7 deletions.
6 changes: 4 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ stages:
include:
- local: '.gitlab/custom-jobs-and-variables.yml'
- project: 'radiuss/radiuss-shared-ci'
ref: 'v2023.12.1'
ref: 'v2024.04.0'
file: 'pipelines/${CI_MACHINE}.yml'
- artifact: '${CI_MACHINE}-jobs.yml'
job: 'generate-job-lists'
Expand All @@ -80,9 +80,11 @@ stages:
pipeline_variables: true

include:
- project: 'lc-templates/id_tokens'
file: 'id_tokens.yml'
# [Optional] checks preliminary to running the actual CI test
#- project: 'radiuss/radiuss-shared-ci'
# ref: 'v2023.12.1'
# ref: 'v2024.04.0'
# file: 'preliminary-ignore-draft-pr.yml'
# pipelines subscribed by the project
- local: '.gitlab/subscribed-pipelines.yml'
4 changes: 2 additions & 2 deletions .gitlab/custom-jobs-and-variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ variables:
RUBY_SHARED_ALLOC: "--exclusive --reservation=ci --time=10 --nodes=2"
# Arguments for job level allocation
# Note: We repeat the reservation, necessary when jobs are manually re-triggered.
RUBY_JOB_ALLOC: "--overlap --reservation=ci --nodes=1"
RUBY_JOB_ALLOC: "--reservation=ci --overlap --nodes=1"
# Project specific variants for ruby
PROJECT_RUBY_VARIANTS: "~shared +fortran +tools tests=basic "
# Project specific deps for ruby
Expand Down Expand Up @@ -45,7 +45,7 @@ variables:

# Tioga
# Arguments for top level allocation
TIOGA_SHARED_ALLOC: "--exclusive --time-limit=15m --nodes=1"
TIOGA_SHARED_ALLOC: "--queue=pci --exclusive --time-limit=15m --nodes=1"
# Arguments for job level allocation
TIOGA_JOB_ALLOC: "--nodes=1 --begin-time=+5s"
# Project specific variants for tioga
Expand Down
2 changes: 1 addition & 1 deletion .uberenv_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"package_final_phase" : "initconfig",
"package_source_dir" : "../..",
"spack_url": "https://github.com/spack/spack.git",
"spack_branch": "develop-2024-02-18",
"spack_branch": "develop-2024-04-21",
"spack_activate" : {},
"spack_configs_path": "scripts/radiuss-spack-configs",
"spack_packages_path": "scripts/radiuss-spack-configs/packages",
Expand Down
10 changes: 10 additions & 0 deletions scripts/gitlab/build_and_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -147,13 +147,23 @@ then
rm -rf ${build_dir} 2>/dev/null
mkdir -p ${build_dir} && cd ${build_dir}

# We set the MPI tests command to allow overlapping.
# Shared allocation: Allows build_and_test.sh to run within a sub-allocation (see CI config).
# Use /dev/shm: Prevent MPI tests from running on a node where the build dir doesn't exist.
cmake_options=""
if [[ "${truehostname}" == "ruby" || "${truehostname}" == "poodle" ]]
then
cmake_options="-DBLT_MPI_COMMAND_APPEND:STRING=--overlap"
fi

date
if [[ "${truehostname}" == "corona" || "${truehostname}" == "tioga" ]]
then
module unload rocm
fi
$cmake_exe \
-C ${hostconfig_path} \
${cmake_options} \
-DCMAKE_INSTALL_PREFIX=${install_dir} \
${project_dir}
if ! $cmake_exe --build . -j; then
Expand Down

0 comments on commit eee3272

Please sign in to comment.