Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: messenger #74

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

module: messenger #74

wants to merge 10 commits into from

Conversation

ErwannLeRoux
Copy link
Collaborator

No description provided.

@ErwannLeRoux ErwannLeRoux force-pushed the module/messenger branch 3 times, most recently from 2f60792 to 25806e5 Compare February 13, 2023 13:47
@ErwannLeRoux ErwannLeRoux force-pushed the module/messenger branch 6 times, most recently from 3c5a2ec to bac390b Compare February 21, 2023 09:43
lcouellan
lcouellan reviewed Mar 9, 2023
View reviewed changes
src/MessageResults/Dinosaur/Create.php Outdated
class Create
{
public function __construct(
public readonly string $id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using id instead of uuid in Module Messenger, we don't have yet the id of the species. For now, I'm using the species name.

@ErwannLeRoux ErwannLeRoux changed the title Module/messenger module: messenger Jun 23, 2023
@ErwannLeRoux ErwannLeRoux force-pushed the master branch 5 times, most recently from de2dfb2 to 9dadb20 Compare July 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcouellan lcouellan lcouellan left review comments

Assignees
No one assigned
Labels
DO NOT MERGE Module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ErwannLeRoux @lcouellan @Zusoy @bricecorreia