docs: add tip about pytest-asyncio fixture and mark.anyio #26
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
reviewed
Oct 15, 2024
Comment on lines
+212
to
+214
| ## 6. Use `pytest-asyncio` fixtures to test your FastAPI and ASGI applications | ||
|
|
||
| When writing fixtures for your FastAPI applications, you should use [pytest-asyncio](pytest-asyncio) to define fixtures. Besides, if your application has a lifespan, you should use [`asgi-lifespan`](asgi-lifespan) to run the lifespan events. |
There was a problem hiding this comment.
That's not really my recommendation... 🤔
I recommend using anyio because you already have the dependency.
There was a problem hiding this comment.
And the asgi-lifespan is mentioned above, no need to mention twice.
|
@baggiponte Do you have time to address my comments? |
|
Ciao @Kludex , sorry for the late reply. Wanted to address them sooner but I'm a bit tight. If you can't wait a bit more you (anyone else?) can go on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ciao! Finally had time to write the PR for #25 😊
Feel free to reword as you wish. I tried to make more explicit the fact that, if your app has a lifespan, you need to use asgi-lifespan.