-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework CMake validation layer options and add flags for best practices and sync validation #737
Rework CMake validation layer options and add flags for best practices and sync validation #737
Conversation
LGTM, but curious, how is this necessary now, #245 suggested these messages should already have been visible? Oh, it looks like it required the user enabling some settings externally, whereas this PR enables them programmatically 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things to consider on this one. It's a good change and we need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While introducing an option for the BEST_PRACTICES layer, we could also introduce an option for SYNCHRONIZATION_VALIDATION ?
Which would make implicit enabling of VALIDATION_LAYER even more important.
I deliberately didn't change how and when the general layer flag is enabled and just expanded the way that the GPU assisted layer works. But sure, I could integrate all of your feedback and rescope the PR. Will take a look at that. |
aabd31a
Description
This PR adds two new CMake options related to validation layers:
VKB_VALIDATION_LAYERS_BEST_PRACTICES
Enables the best practices layer.
VKB_VALIDATION_LAYERS_SYNCHRONIZATION
Enables the synchronization validation layer.
These flags let developers easily toggle what part of the validation layers are active without having to e.g. use vkconfig from SDK.
Enabling one of these flags also implicitly enables validation layers. This was also retrofitted for the already existing
VKB_VALIDATION_LAYERS_GPU_ASSISTED
. So as soon as one of these flags is set, validation layers are enabled. This makes them less confusing to use.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: