Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for SPV_INTEL_global_variable_host_access #5786

Merged
merged 1 commit into from
Sep 17, 2024
Merged

add support for SPV_INTEL_global_variable_host_access #5786

merged 1 commit into from
Sep 17, 2024

Conversation

bashbaug
Copy link
Contributor

@bashbaug bashbaug commented Sep 5, 2024

Adds support for the "Host Access Qualifier" operand type used by SPV_INTEL_global_variable_host_access.

dneto0
dneto0 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I cross-checked with the grammar rules for the HostAccessINTEL decoration and the HostAccessQualifier enum.

Thanks for your patience.

@dneto0 dneto0 merged commit 20788a4 into KhronosGroup:main Sep 17, 2024
24 checks passed
@bashbaug bashbaug deleted the SPV_INTEL_global_variable_host_access branch September 17, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

@alan-baker alan-baker alan-baker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bashbaug @dneto0 @alan-baker