Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIR-V 1.4] Deprecate OpDecorationGroup, OpGroupDecorate, and OpGroupMemberDecorate #2667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vmaksimo
Copy link
Contributor

@vmaksimo vmaksimo commented Aug 8, 2024

No description provided.

getModule()->getErrorLog().checkError(
this->getModule()->getSPIRVVersion() < VersionNumber::SPIRV_1_4,
SPIRVEC_InvalidModule,
"OpGroup(Member)Decorate is deprecated starting from SPIR-V 1.4");
Copy link
Contributor

@LU-JOHN LU-JOHN Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe re-write as:

"OpGroupDecorate and OpGroupMemberDecorate are deprecated starting from SPIR-V 1.4"

@bashbaug
Copy link
Contributor

Note, in the SPIR-V spec deprecation doesn't mean removal: https://registry.khronos.org/SPIR-V/specs/unified1/SPIRV.html#_deprecation

Additionally, it doesn't appear that the SPIR-V validator flags a SPIR-V 1.4 module using these instructions as invalid.

I think it would be fine to identify use of these deprecated instructions with a warning, but failing translation seems a bit too strong.

@vmaksimo
Copy link
Contributor Author

I think it would be fine to identify use of these deprecated instructions with a warning, but failing translation seems a bit too strong.

@bashbaug I agree, but unfortunately for now we don't have a mechanism to report a warning in llvm-spirv (am I wrong?).
If so, I think that maybe it'd be a solution to just ignore and close this PR, as it does not change much.

@vmaksimo vmaksimo requested a review from LU-JOHN October 1, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants