[Backport to 18] Add SPV_INTEL_bindless_images preview extension (#2535) #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSidims
changed the title
MrSidims
force-pushed
the
llvm_release_180-image
branch
from
d96cb74
to
f36a3de
Compare
asudarsa
reviewed
Apr 26, 2024
| @@ -668,7 +668,8 @@ template <> inline void SPIRVMap<Capability, std::string>::init() { | |||
| "CooperativeMatrixInvocationInstructionsINTEL"); | |||
| add(internal::CapabilityCooperativeMatrixCheckedInstructionsINTEL, | |||
| "CooperativeMatrixCheckedInstructionsINTEL"); | |||
| add(internal::CapabilityRegisterLimitsINTEL, "RegisterLimitsINTEL"); | |||
| add(internal::CapabilityTaskSequenceINTEL, "TaskSequenceINTEL"); | |||
There was a problem hiding this comment.
This seems to cause test fails. I suppose you would have noticed as well. Will review after fixing. Thanks much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification: https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_bindless_images.asciidoc
Co-author: He, Wenju [email protected]