Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add properties parameter to all command-buffer commands #1215

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Jul 24, 2024

See Issue #1207 discussion how it could make the cl_khr_command_buffer extension more extensible if we allowed all the command-recording parameters to have a properties parameter that could be used.

Closes #1207

Related PRs:

@EwanC EwanC added the cl_khr_command_buffer Relating to the command-buffer family of extension label Jul 24, 2024
@EwanC EwanC requested a review from kpet July 24, 2024 09:07
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big breaking change that will affect pretty much all code that uses command buffers, but the extension still is provisional and I agree it would be a good idea to build in extensibility.

api/cl_khr_command_buffer.asciidoc Outdated Show resolved Hide resolved
EwanC added a commit to EwanC/OpenCL-Headers that referenced this pull request Aug 14, 2024
Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215
to address KhronosGroup/OpenCL-Docs#1207

A new `cl_command_properties_khr` properties parameter is added
to all command recording entry-points, and the patch version is
bumped.
EwanC added a commit to EwanC/OpenCL-CTS that referenced this pull request Aug 15, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215
and requires header change KhronosGroup/OpenCL-Headers#260
to use preprocessor path with extra parameters
EwanC added a commit to EwanC/OpenCL-CTS that referenced this pull request Aug 15, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215
and requires header change KhronosGroup/OpenCL-Headers#260
to use preprocessor path with extra parameters
EwanC added a commit to EwanC/oneapi-construction-kit that referenced this pull request Aug 15, 2024
Update cl_khr_command_buffer API to match breaking change
from KhronosGroup/OpenCL-Docs#1215
@bashbaug
Copy link
Contributor

bashbaug commented Sep 3, 2024

Merging after final review, as discussed in the September 3rd teleconference.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine merging this ASAP - it's probably better to get these changes in sooner rather than later.

api/opencl_runtime_layer.asciidoc Show resolved Hide resolved
api/opencl_runtime_layer.asciidoc Outdated Show resolved Hide resolved
EwanC and others added 4 commits September 5, 2024 13:15
See Issue KhronosGroup#1207
disucssion how it could make the `cl_khr_command_buffer` extension
more extensible if we allowed all the command-recording parameters
to have a `properties` parameter that could be used.
EwanC added a commit to EwanC/OpenCL-CLHPP that referenced this pull request Sep 5, 2024
EwanC added a commit to EwanC/OpenCL-Headers that referenced this pull request Sep 5, 2024
Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215
to address KhronosGroup/OpenCL-Docs#1207

A new `cl_command_properties_khr` properties parameter is added
to all command recording entry-points, and the patch version is
bumped.
EwanC added a commit to EwanC/OpenCL-CTS that referenced this pull request Sep 5, 2024
Make changes to reflect OpenCL-Docs change KhronosGroup/OpenCL-Docs#1215
and requires header change KhronosGroup/OpenCL-Headers#260
to use preprocessor path with extra parameters
@bashbaug
Copy link
Contributor

bashbaug commented Sep 6, 2024

Merging as discussed in the September 3rd teleconference + email.

@bashbaug bashbaug merged commit 0134139 into KhronosGroup:main Sep 6, 2024
2 checks passed
bashbaug added a commit to KhronosGroup/OpenCL-Headers that referenced this pull request Sep 6, 2024
* Add properties parameter to all command-buffer commands

Header changes to reflect XML changes from KhronosGroup/OpenCL-Docs#1215
to address KhronosGroup/OpenCL-Docs#1207

A new `cl_command_properties_khr` properties parameter is added
to all command recording entry-points, and the patch version is
bumped.

* Rename CL_MUTABLE_COMMAND_PROPERTIES_ARRAY_KHR

---------

Co-authored-by: Ben Ashbaugh <[email protected]>
bashbaug pushed a commit to KhronosGroup/OpenCL-CLHPP that referenced this pull request Sep 6, 2024
* Add properties parameter to all command-buffer commands

Updates to compile with header change KhronosGroup/OpenCL-Headers#260

* Update to reflect CL_MUTABLE_COMMAND_PROPERTIES_ARRAY_KHR

See  KhronosGroup/OpenCL-Docs#1215 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl_khr_command_buffer Relating to the command-buffer family of extension
Development

Successfully merging this pull request may close these issues.

Do we want a path to provide properties for all command types defined by cl_khr_command_buffer?
3 participants