Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Kamelet catalog version to 4.8 in embedded catalog #1536

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

apupier
Copy link
Member

@apupier apupier commented Oct 4, 2024

No description provided.

@apupier
Copy link
Member Author

apupier commented Oct 4, 2024

one test in error:

 [@kaoto/kaoto]: FAIL src/components/PropertiesModal/PropertiesModal.test.tsx (8.577 s)
[@kaoto/kaoto]:   ● PropertiesModal › Kamelet tile › renders property modal correctly
[@kaoto/kaoto]: 
[@kaoto/kaoto]:     expect(element).toHaveTextContent()
[@kaoto/kaoto]: 
[@kaoto/kaoto]:     Expected element to have text content:
[@kaoto/kaoto]:       Options (9)
[@kaoto/kaoto]:     Received:
[@kaoto/kaoto]:       Options (13)
[@kaoto/kaoto]: 
[@kaoto/kaoto]:       233 |       );
[@kaoto/kaoto]:       234 |       expect(screen.getByTestId('properties-modal-description')).toHaveTextContent('Receive events');
[@kaoto/kaoto]:     > 235 |       expect(screen.getByTestId('tab-0')).toHaveTextContent('Options (9)');
[@kaoto/kaoto]:           |                                           ^
[@kaoto/kaoto]:       236 |       // headers
[@kaoto/kaoto]:       237 |       expect(screen.getByTestId('tab-0-table-0-header-property')).toHaveTextContent('property');
[@kaoto/kaoto]:       238 |       expect(screen.getByTestId('tab-0-table-0-header-name')).toHaveTextContent('name');
[@kaoto/kaoto]: 
[@kaoto/kaoto]:       at Object.toHaveTextContent (src/components/PropertiesModal/PropertiesModal.test.tsx:235:43)

@lordrip
Copy link
Member

lordrip commented Oct 4, 2024

one test in error:

It looks like Kamelets have more properties now. Updating the test to (13) would be ok

Copy link

sonarcloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1ea7704). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1536   +/-   ##
=======================================
  Coverage        ?   80.02%           
  Complexity      ?      259           
=======================================
  Files           ?      276           
  Lines           ?     7755           
  Branches        ?     1520           
=======================================
  Hits            ?     6206           
  Misses          ?     1441           
  Partials        ?      108           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apupier apupier merged commit c86891f into KaotoIO:main Oct 4, 2024
12 checks passed
@apupier apupier deleted the updateKameletsTo4.8 branch October 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants