chore: Add askUserForFileSelection() in KaotoEditorChannelApi #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordrip
approved these changes
Oct 3, 2024
lordrip
reviewed
Oct 3, 2024
| @@ -45,4 +45,16 @@ export interface KaotoEditorChannelApi extends KogitoEditorChannelApi { | |||
| * @return If the deletion was done succesfully | |||
| */ | |||
| deleteResource(path: string): Promise<boolean>; | |||
|
|
|||
| /** | |||
| * Show a Quick Pick widget and ask the user to select one or more files available in the workspace. | |||
There was a problem hiding this comment.
Just a bit of food for thought, it's possible that this API might be implemented differently in the browser, perhaps in the form of a standard file picker
There was a problem hiding this comment.
Good point, updated the doc not to be too specific to VS Code.
igarashitm
force-pushed
the
askUserForFileSelection
branch
from
9bc779d
to
081b19f
Compare
igarashitm
force-pushed
the
askUserForFileSelection
branch
from
081b19f
to
0b0556f
Compare
|
lordrip
approved these changes
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1528 +/- ##
=======================================
Coverage ? 69.73%
Complexity ? 62
=======================================
Files ? 276
Lines ? 7752
Branches ? 1518
=======================================
Hits ? 5406
Misses ? 2344
Partials ? 2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.