Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract l/rmul and l/rdiv types #137

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Abstract l/rmul and l/rdiv types #137

wants to merge 5 commits into from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 13, 2023

This defines abstract types for LMul/RMul/LDiv/RDiv, and defines some of the methods for the supertypes rather than the specific types.

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (14721f1) 87.08% compared to head (9f96e09) 87.09%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   87.08%   87.09%   +0.01%     
==========================================
  Files          10       10              
  Lines        1773     1775       +2     
==========================================
+ Hits         1544     1546       +2     
  Misses        229      229              
Files Changed Coverage Δ
src/ldiv.jl 90.40% <100.00%> (+0.07%) ⬆️
src/lmul.jl 90.90% <100.00%> (+0.13%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub requested a review from dlfivefifty June 13, 2023 09:02
@dlfivefifty
Copy link
Member

What's the motivation for this?

@jishnub
Copy link
Member Author

jishnub commented Jun 14, 2023

To reduce the number of methods that need to be defined, which may improve the package-load and compile times slightly (although I haven't benchmarked these). From a design perspective, it seems redundant to define identical methods for every subtype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants