Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove openlibm #56875

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

inkydragon
Copy link
Member

See if we've got some progress for #42299

After using gcc14 and updating the CSL,
I was able to build successfully locally and pass most of the stable tests.
Let's see if we can build successfully on the mainline and pass the tests.

@inkydragon inkydragon added the DO NOT MERGE Do not merge this PR! label Dec 20, 2024
@inkydragon

This comment was marked as outdated.

@inkydragon
Copy link
Member Author

I had a crazy idea: since libc on windows (msvcrt) is missing some functions, let's wrap and use those functions from C++ (libstdc++).

Comment on lines +483 to +489
# For test only
# https://github.com/JuliaLang/julia/pull/56875
# Only build on windows
ifneq ($(OS), WINNT)
# not on win32
$(error "JuliaLang/julia#56875" Only build on windows)
endif
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge this pr.

@inkydragon
Copy link
Member Author

With newer msvcrt from gcc14, we can build julia-x64 without openblibm
https://buildkite.com/julialang/julia-master/builds/43184#0193e4ca-544e-43fd-b419-b3c2d245ba39

@inkydragon inkydragon force-pushed the cyhan/remove-openlibm branch from 5a78588 to fde32eb Compare December 21, 2024 08:27
@inkydragon
Copy link
Member Author

@giordano
Copy link
Contributor

With newer msvcrt from gcc14, we can build julia-x64 without openblibm

Does this mean that on Windows we'd need to require a very recent compiler?

@inkydragon
Copy link
Member Author

Does this mean that on Windows we'd need to require a very recent compiler?

MSYS2 only keeps the latest version of the package, so GCC 14 is used here.

Maybe a newer version of gcc isn't necessary, but I haven't tested it yet.
I guess just using the mingw toolchain and linking to mingw32, mingwex, msvcrt would be an alternative to openlibm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants