Add custom MIME types to display_dict. #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twavv
changed the title
|
Ping @stevengj Could you please take a look at this? |
stevengj
reviewed
Oct 8, 2018
src/execute_request.jl
Outdated
| MIME("text/plain"), | ||
| MIME("image/svg+xml"), | ||
| MIME("image/png"), | ||
| MIME("image/jpeg"), |
There was a problem hiding this comment.
png and jpeg should be in a vector to have the same behavior as before
stevengj
reviewed
Oct 8, 2018
stevengj
reviewed
Oct 8, 2018
src/execute_request.jl
Outdated
| [MIME("application/vnd.vegalite.v2+json"), MIME("application/vnd.vega.v3+json")], | ||
| ]) | ||
|
|
||
| register_ijulia_mime(x::Union{MIME, Vector{MIME}}) = push!(ijulia_mime_types, x) |
There was a problem hiding this comment.
No ijulia here since that is already in the module name. i.e. IJulia.register_mime
stevengj
reviewed
Oct 8, 2018
|
@stevengj I believe I've resolved all of those |
stevengj
reviewed
Oct 8, 2018
|
Done! :^) |
stevengj
reviewed
Oct 9, 2018
stevengj
reviewed
Oct 9, 2018
stevengj
reviewed
Oct 9, 2018
|
😄 Thanks for the guidance! |
|
Thanks for persisting on this! |
|
Could you do a minor release so that I can depend on this in WebIO? |
|
I was hoping to merge #756 first once it is ready, but I will check back later today. |
|
tagged 1.13 |
cnliao
pushed a commit
to cnliao/IJulia.jl
that referenced
this pull request
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #749.
I think this is especially prudent given JupyterLab's focus on implementing custom MIME types rather than just rendering everything as HTML with JavaScript.
Very much open to comments (especially with regards to style and best practices!) and critiques.