Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support negative k for k-subsets #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stev47
Copy link

@stev47 stev47 commented Aug 7, 2019

We have binomial(n, k)=0 for k<0 and k>n.
This makes subsets comply accordingly instead of creating wrong iterators or throwing errors.

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

Merging #63 into master will increase coverage by 0.25%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   67.57%   67.82%   +0.25%     
==========================================
  Files           1        1              
  Lines         256      258       +2     
==========================================
+ Hits          173      175       +2     
  Misses         83       83
Impacted Files Coverage Δ
src/IterTools.jl 67.82% <66.66%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a26e26...c43cd24. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants