Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan_(b)rfft types as in FFTW #17

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

milankl
Copy link
Collaborator

@milankl milankl commented Sep 2, 2022

This should address #14

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Base: 69.39% // Head: 69.39% // No change to project coverage 👍

Coverage data is based on head (64969bd) compared to base (76f3a0c).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   69.39%   69.39%           
=======================================
  Files           2        2           
  Lines         183      183           
=======================================
  Hits          127      127           
  Misses         56       56           
Impacted Files Coverage Δ
src/fft.jl 69.66% <81.81%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@milankl milankl requested a review from daanhb September 2, 2022 13:08
@daanhb
Copy link
Member

daanhb commented Sep 2, 2022

Since the documentation of AbstractFFTs.jl says the following

# DFT plan where the inputs are an array of eltype T
abstract type Plan{T} end

I think this change is the right thing to do. By modifying T upon construction of the plan we were removing information.

@daanhb
Copy link
Member

daanhb commented Sep 2, 2022

We have to remember to decide on a release number, I think this should be 0.2.

@milankl
Copy link
Collaborator Author

milankl commented Sep 2, 2022

Before we tag it as v0.2 I thought about getting the sizes into the plans too as raised in #10 ?

@daanhb
Copy link
Member

daanhb commented Sep 2, 2022

Yes, sure. I'll merge this and we can change the version number later.

@daanhb daanhb merged commit fc6bea9 into JuliaApproximation:main Sep 2, 2022
@daanhb
Copy link
Member

daanhb commented Sep 2, 2022

(I forgot you could merge yourself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants