add sample for text version of find #5368
Conversation
SvyatoslavScherbina
added
the
Standard Library Sample
| * | ||
| * @sample samples.collections.Collections.Elements.find | ||
| * | ||
| * @sample samples.text.Strings.find |
There was a problem hiding this comment.
@RohitGupta200 please make sure that these generated files are updated via :tools:kotlin-stdlib-gen:run command.
See https://github.com/JetBrains/kotlin/blob/master/libraries/stdlib/ReadMe.md#code-generation for details.
| specialFor(CharSequences) { | ||
| sample("samples.text.Strings.find") | ||
| } | ||
| specialFor(ArraysOfUnsigned) { |
There was a problem hiding this comment.
The original sample call should be left as is, without any additional specialFor predicates, and the call generating a sample specialized for char sequences should be placed right after it (wrapped into a predicate):
sample("samples.collections.Collections.Elements.find")
specialFor(CharSequences) {
sample("samples.text.Strings.find")
}
| @@ -435,6 +435,18 @@ class Strings { | |||
| assertPrints(matchDetails(inputString, toFind, 10), "Searching for 'ever' in 'Never ever give up' starting at position 10: Not found") | |||
| } | |||
|
|
|||
| @Sample | |||
| fun find() { | |||
There was a problem hiding this comment.
This sample is not compilable, please run it locally before submitting the updated version.
| @@ -435,6 +435,18 @@ class Strings { | |||
| assertPrints(matchDetails(inputString, toFind, 10), "Searching for 'ever' in 'Never ever give up' starting at position 10: Not found") | |||
| } | |||
|
|
|||
| @Sample | |||
| fun find() { | |||
| val text = "k1o2t3l4i5n6" | |||
There was a problem hiding this comment.
Consider using a slightly more readable string, like "kotlin 2.1.0".
While it won't affect correctness, it would be much easier to understand which characters are digits and which are letters (distinguishing l from 1 might be tricky depending on a type font).
| fun find() { | ||
| val text = "k1o2t3l4i5n6" | ||
|
|
||
| val firstNumberInText = text.find { it.isDigit() } |
There was a problem hiding this comment.
Please inline an expression that uses find into assertPrints call (for example, like in the sample for last). A temporary variable doesn't add an additional context here and only distracts from grasping the semantics.
There was a problem hiding this comment.
Well, it adds some context, but it might be better to add an explicit comment like // the index of the first digit, '1' and // the string does not contain uppercase letters.
KT-35867 - Adds samples to Text find() function.