automate OL7 updates #487
Open
automate OL7 updates #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modify scripts for building images from Oracle Linux 7 - update jb/build/VerifyDependencies.java to check libraries have no dependency on symbols from glibc version higher than 2.17
mkartashev
requested changes
Dec 26, 2024
| devtoolset-10-binutils-2.35-5.el7.4 \ | ||
| devtoolset-10-gcc-10.2.1-11.2.0.2.el7 \ | ||
| devtoolset-10-gcc-c++-10.2.1-11.2.0.2.el7 | ||
| RUN yum -y install \ |
There was a problem hiding this comment.
It's best to have as little RUN commands as possible to reduce the number of layers and get a smaller image.
| COPY scl.repo /etc/yum.repos.d/ | ||
|
|
||
| # Install the necessary build tools | ||
| RUN yum -y update; \ |
There was a problem hiding this comment.
Let's combine operations with && rather than ';. Otherwise it's easy to miss an error generated by an earlier command.
| @@ -0,0 +1,57 @@ | |||
| # NOTE: This Dockerfile is meant to be used from the mkdocker_64.sh script. | |||
There was a problem hiding this comment.
mkdocker_64.sh -> mkdocker_x64.sh
| BOOT_JDK_REMOTE_FILE=zulu17.30.15-ca-jdk17.0.1-linux_aarch64.tar.gz | ||
| BOOT_JDK_SHA=4d9c9116eb0cdd2d7fb220d6d27059f4bf1b7e95cc93d5512bd8ce3791af86c7 | ||
| BOOT_JDK_LOCAL_FILE=boot_jdk.tar.gz | ||
| echo "ULN username:"; |
There was a problem hiding this comment.
There should be no need for ; at the end of these lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.