Fix PBR Reflections #2599
Open
Fix PBR Reflections #2599
+57
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Converting this to a draft after finding a couple problems in MER processing. |
Corrected normal scale once more to match DirectX style.
Updated MER processing logic to: - Use green channel as a mask instead of value - Add roughness multiplier when MER is present
|
Updated accuracy of MER usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ought to help with the reflections in the Material Preview. Here's what has changed:
normalScaleto flip the normal map to use right-handed (DirectX) normal maps for RenderDragon compatibility..textureproperty for theenvMapUpon initially loading a scene, the environment may appear too dark without a cubemap preset. The scene's lights will still reflect off the model without the cubemap.
Here is the reflection with a preview scene activated and the material updated.
Screen.Recording.2024-12-22.142857.mp4