fix issues with auth (modrinth#1247)

Jakobabs · Aug 1, 2023 · 04915cc · 04915cc
1 parent e2fb882
commit 04915cc
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 8 deletions.
diff --git a/components/ui/NotificationItem.vue b/components/ui/NotificationItem.vue
@@ -118,7 +118,7 @@
         >
           <VersionIcon />
           <nuxt-link
-            :to="getVersionLink(notif.extra_data.project, notif.extra_data.version.name)"
+            :to="getVersionLink(notif.extra_data.project, notif.extra_data.version)"
             class="text-link no-underline"
           >
             {{ notif.extra_data.version.name }}

diff --git a/helpers/notifications.js b/helpers/notifications.js
@@ -126,6 +126,11 @@ export async function fetchNotifications() {
 
 export function groupNotifications(notifications, includeRead = false) {
   const grouped = []
+
+  for (const notification of notifications) {
+    notification.grouped_notifs = []
+  }
+
   for (const notification of notifications.filter((notif) => includeRead || !notif.read)) {
     // Group notifications of the same thread or project id
     if (notification.body) {

diff --git a/pages/auth.vue b/pages/auth.vue
@@ -142,6 +142,9 @@ const route = useRoute()
   }
 
   @media screen and (max-width: 25.5rem) {
+    width: auto;
+    margin: 1rem;
+
     .third-party .btn {
       grid-column: 1 / 3;
     }

diff --git a/pages/auth/sign-up.vue b/pages/auth/sign-up.vue
@@ -33,7 +33,11 @@
       type="password"
       placeholder="Confirm password"
     />
-    <Checkbox v-model="subscribe" class="subscribe-btn" label="Subscribe updates about Modrinth" />
+    <Checkbox
+      v-model="subscribe"
+      class="subscribe-btn"
+      label="Subscribe to updates about Modrinth"
+    />
     <p>
       By creating an account, you agree to Modrinth's
       <nuxt-link to="/legal/terms" class="text-link">terms</nuxt-link> and
@@ -43,7 +47,7 @@
       Create account <RightArrowIcon />
     </button>
     <p>
-      Already have an account yet?
+      Already have an account?
       <nuxt-link
         class="text-link"
         :to="`/auth/sign-in${route.query.redirect ? `?redirect=${route.query.redirect}` : ''}`"

diff --git a/pages/auth/welcome.vue b/pages/auth/welcome.vue
@@ -5,7 +5,11 @@
       Thank you for creating an account. You can now follow and create projects, receive updates
       about your favorite projects, and more!
     </p>
-    <Checkbox v-model="subscribe" class="subscribe-btn" label="Subscribe updates about Modrinth" />
+    <Checkbox
+      v-model="subscribe"
+      class="subscribe-btn"
+      label="Subscribe to updates about Modrinth"
+    />
     <button class="btn btn-primary continue-btn" @click="continueSignUp">Continue</button>
     <p>
       By creating an account, you agree to Modrinth's

diff --git a/pages/index.vue b/pages/index.vue
@@ -25,7 +25,7 @@
         <nuxt-link to="/mods" class="iconified-button brand-button"> Discover mods </nuxt-link>
         <nuxt-link
           v-if="!auth.user"
-          to="sign-up"
+          to="/auth/sign-up"
           class="iconified-button outline-button"
           rel="noopener nofollow"
         >

diff --git a/pages/settings/account.vue b/pages/settings/account.vue
@@ -255,9 +255,9 @@
         </div>
         <p></p>
         <div class="input-group push-right">
-          <button class="iconified-button brand-button" @click="$refs.manageProvidersModal.hide()">
-            <CheckIcon />
-            Finish editing
+          <button class="iconified-button" @click="$refs.manageProvidersModal.hide()">
+            <XIcon />
+            Close
           </button>
         </div>
       </div>