Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NodeToNodeV_12 older #4985

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Remove NodeToNodeV_12 older #4985

merged 3 commits into from
Oct 10, 2024
+141 −433

Conversation

crocodile-dentist
Copy link
Contributor

Description

Removes support for NodeToNodeV_12 and older as these are unable to cross the hard fork boundary.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@crocodile-dentist crocodile-dentist requested a review from a team as a code owner October 8, 2024 19:53
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/remove-nodetonode-v12-older branch 7 times, most recently from 1da0444 to 0a75b40 Compare October 9, 2024 07:30
coot
coot approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ouroboros-network/sim-tests-lib/Ouroboros/Network/BlockFetch/Examples.hs Outdated Show resolved Hide resolved
karknu
karknu requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the encoding/decoding of older versions.

ouroboros-network-api/src/Ouroboros/Network/NodeToNode/Version.hs Outdated Show resolved Hide resolved
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/remove-nodetonode-v12-older branch from 0a75b40 to a20463a Compare October 9, 2024 09:32
@crocodile-dentist
Copy link
Contributor Author

@coot @karknu
Should I also remove https://github.com/IntersectMBO/ouroboros-network/blob/master/ouroboros-network-api/src/Ouroboros/Network/PeerSelection/PeerSharing/Codec.hs#L44-L59
and
https://github.com/IntersectMBO/ouroboros-network/blob/master/ouroboros-network-api/src/Ouroboros/Network/PeerSelection/PeerSharing/Codec.hs#L84-L101
?

@karknu
Copy link
Contributor

karknu commented Oct 9, 2024

@coot @karknu Should I also remove https://github.com/IntersectMBO/ouroboros-network/blob/master/ouroboros-network-api/src/Ouroboros/Network/PeerSelection/PeerSharing/Codec.hs#L44-L59 and https://github.com/IntersectMBO/ouroboros-network/blob/master/ouroboros-network-api/src/Ouroboros/Network/PeerSelection/PeerSharing/Codec.hs#L84-L101 ?

Yeah, that should go too.

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/remove-nodetonode-v12-older branch from a20463a to 2dee544 Compare October 9, 2024 13:52
karknu
karknu approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@karknu karknu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/remove-nodetonode-v12-older branch from 2dee544 to cd65b5a Compare October 9, 2024 14:38
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/remove-nodetonode-v12-older branch 2 times, most recently from cd65b5a to d2d90a8 Compare October 9, 2024 21:02
@crocodile-dentist crocodile-dentist force-pushed the mwojtowicz/remove-nodetonode-v12-older branch from d2d90a8 to 9e45f34 Compare October 10, 2024 07:31
@crocodile-dentist crocodile-dentist added this pull request to the merge queue Oct 10, 2024
Merged via the queue into master with commit dad8b19 Oct 10, 2024
11 of 12 checks passed
@crocodile-dentist crocodile-dentist deleted the mwojtowicz/remove-nodetonode-v12-older branch October 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@karknu karknu karknu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ouroboros Network
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crocodile-dentist @karknu @coot