Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: refatored how shell & tools are provided #4969

Merged
merged 18 commits into from
Oct 1, 2024
Merged

Conversation

coot
Copy link
Contributor

@coot coot commented Sep 28, 2024

No description provided.

@coot coot requested review from a team as code owners September 28, 2024 08:12
@coot coot requested a review from bolt12 September 28, 2024 08:12
@coot coot force-pushed the coot/nix-devShells branch 2 times, most recently from eef86fb to ad1f3d8 Compare September 28, 2024 08:46
Copy link
Contributor

@semanticphilosopher semanticphilosopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems reasonable to me

@coot
Copy link
Contributor Author

coot commented Sep 28, 2024

@semanticphilosopher I am stealing ideas from the ouroboros-consensus repo, without making it too hard to understand what's going on.

@coot
Copy link
Contributor Author

coot commented Sep 28, 2024

@semanticphilosopher you need to review as @njd42, we only have your latter account in the @IntersectMBO/ouroboros-network-maintainers.

@coot coot force-pushed the coot/nix-devShells branch 5 times, most recently from 4493652 to ca9b54f Compare September 30, 2024 06:05
@coot coot self-assigned this Sep 30, 2024
@coot coot added nix This includes CI, nix changes or cabal dependencies CI Issues / PRs related to CI labels Sep 30, 2024
@coot coot force-pushed the coot/nix-devShells branch 7 times, most recently from 9685d18 to 0563ea6 Compare September 30, 2024 08:26
nix/ouroboros-network.nix Outdated Show resolved Hide resolved
@coot coot force-pushed the coot/nix-devShells branch 5 times, most recently from 230f12b to cc3b2e5 Compare September 30, 2024 15:24
@coot coot force-pushed the coot/nix-devShells branch 2 times, most recently from c09ff3d to cf6ebe3 Compare September 30, 2024 16:49
We no longer use `srp` for dependency management, thus the script is no
longer needed.
* Added explicit cabal.project
* Removed `-Werror` flags in nix, they are set in `cabal.project.local`
  files.
* Used `doCheckCross` instead of setting `doCheck` flag per package.
```
nix develop .\#profiling
```

It will enter a nix shell with profiling environment for `ghc-9.8`.
The only supported way to start one of the provides shells is by using
`nix develop`.
Added a convenient way to run all formatters.
@coot coot added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit 2b0fa5b Oct 1, 2024
13 of 14 checks passed
@coot coot deleted the coot/nix-devShells branch October 1, 2024 10:31
crocodile-dentist pushed a commit that referenced this pull request Oct 3, 2024
* dependabot: remove misnamed script

We still have `.github/dependabot.yml`.

* nix: refactored how shell & tools are provided

* ouroboros-network-framework: removed unused extensions

* nix: stylish-haskell formatting

* nix: format nix files with nixpkgs-fmt

* formatted nix files with nixpkg-fmt

* nix: format cabal files with cabal-gild

* formated cabal files with cabal-gild

* GHA: removed check-git-dependencies

We no longer use `srp` for dependency management, thus the script is no
longer needed.

* nix: run `cabal check`

* nix: removed formatter field

* tx-submission: fixed a nothunk violation in a test

I made the `getTxSize` field of `Tx` strict.
Ref: https://ci.iog.io/build/5515353/nixlog/1

* nix: ouroboros-network

* Added explicit cabal.project
* Removed `-Werror` flags in nix, they are set in `cabal.project.local`
  files.
* Used `doCheckCross` instead of setting `doCheck` flag per package.

* nix: added profiling shell

```
nix develop .\#profiling
```

It will enter a nix shell with profiling environment for `ghc-9.8`.

* nix: build documentation, formats & shell only on `x86_64-linux`

* nix: removed nsh.sh script

* nix: removed shell.nix file

The only supported way to start one of the provides shells is by using
`nix develop`.

* nix: nix build .\#format.all

Added a convenient way to run all formatters.
crocodile-dentist pushed a commit that referenced this pull request Oct 3, 2024
* dependabot: remove misnamed script

We still have `.github/dependabot.yml`.

* nix: refactored how shell & tools are provided

* ouroboros-network-framework: removed unused extensions

* nix: stylish-haskell formatting

* nix: format nix files with nixpkgs-fmt

* formatted nix files with nixpkg-fmt

* nix: format cabal files with cabal-gild

* formated cabal files with cabal-gild

* GHA: removed check-git-dependencies

We no longer use `srp` for dependency management, thus the script is no
longer needed.

* nix: run `cabal check`

* nix: removed formatter field

* tx-submission: fixed a nothunk violation in a test

I made the `getTxSize` field of `Tx` strict.
Ref: https://ci.iog.io/build/5515353/nixlog/1

* nix: ouroboros-network

* Added explicit cabal.project
* Removed `-Werror` flags in nix, they are set in `cabal.project.local`
  files.
* Used `doCheckCross` instead of setting `doCheck` flag per package.

* nix: added profiling shell

```
nix develop .\#profiling
```

It will enter a nix shell with profiling environment for `ghc-9.8`.

* nix: build documentation, formats & shell only on `x86_64-linux`

* nix: removed nsh.sh script

* nix: removed shell.nix file

The only supported way to start one of the provides shells is by using
`nix develop`.

* nix: nix build .\#format.all

Added a convenient way to run all formatters.
crocodile-dentist pushed a commit that referenced this pull request Oct 10, 2024
* dependabot: remove misnamed script

We still have `.github/dependabot.yml`.

* nix: refactored how shell & tools are provided

* ouroboros-network-framework: removed unused extensions

* nix: stylish-haskell formatting

* nix: format nix files with nixpkgs-fmt

* formatted nix files with nixpkg-fmt

* nix: format cabal files with cabal-gild

* formated cabal files with cabal-gild

* GHA: removed check-git-dependencies

We no longer use `srp` for dependency management, thus the script is no
longer needed.

* nix: run `cabal check`

* nix: removed formatter field

* tx-submission: fixed a nothunk violation in a test

I made the `getTxSize` field of `Tx` strict.
Ref: https://ci.iog.io/build/5515353/nixlog/1

* nix: ouroboros-network

* Added explicit cabal.project
* Removed `-Werror` flags in nix, they are set in `cabal.project.local`
  files.
* Used `doCheckCross` instead of setting `doCheck` flag per package.

* nix: added profiling shell

```
nix develop .\#profiling
```

It will enter a nix shell with profiling environment for `ghc-9.8`.

* nix: build documentation, formats & shell only on `x86_64-linux`

* nix: removed nsh.sh script

* nix: removed shell.nix file

The only supported way to start one of the provides shells is by using
`nix develop`.

* nix: nix build .\#format.all

Added a convenient way to run all formatters.
crocodile-dentist pushed a commit that referenced this pull request Oct 10, 2024
* dependabot: remove misnamed script

We still have `.github/dependabot.yml`.

* nix: refactored how shell & tools are provided

* ouroboros-network-framework: removed unused extensions

* nix: stylish-haskell formatting

* nix: format nix files with nixpkgs-fmt

* formatted nix files with nixpkg-fmt

* nix: format cabal files with cabal-gild

* formated cabal files with cabal-gild

* GHA: removed check-git-dependencies

We no longer use `srp` for dependency management, thus the script is no
longer needed.

* nix: run `cabal check`

* nix: removed formatter field

* tx-submission: fixed a nothunk violation in a test

I made the `getTxSize` field of `Tx` strict.
Ref: https://ci.iog.io/build/5515353/nixlog/1

* nix: ouroboros-network

* Added explicit cabal.project
* Removed `-Werror` flags in nix, they are set in `cabal.project.local`
  files.
* Used `doCheckCross` instead of setting `doCheck` flag per package.

* nix: added profiling shell

```
nix develop .\#profiling
```

It will enter a nix shell with profiling environment for `ghc-9.8`.

* nix: build documentation, formats & shell only on `x86_64-linux`

* nix: removed nsh.sh script

* nix: removed shell.nix file

The only supported way to start one of the provides shells is by using
`nix develop`.

* nix: nix build .\#format.all

Added a convenient way to run all formatters.
crocodile-dentist pushed a commit that referenced this pull request Oct 10, 2024
* dependabot: remove misnamed script

We still have `.github/dependabot.yml`.

* nix: refactored how shell & tools are provided

* ouroboros-network-framework: removed unused extensions

* nix: stylish-haskell formatting

* nix: format nix files with nixpkgs-fmt

* formatted nix files with nixpkg-fmt

* nix: format cabal files with cabal-gild

* formated cabal files with cabal-gild

* GHA: removed check-git-dependencies

We no longer use `srp` for dependency management, thus the script is no
longer needed.

* nix: run `cabal check`

* nix: removed formatter field

* tx-submission: fixed a nothunk violation in a test

I made the `getTxSize` field of `Tx` strict.
Ref: https://ci.iog.io/build/5515353/nixlog/1

* nix: ouroboros-network

* Added explicit cabal.project
* Removed `-Werror` flags in nix, they are set in `cabal.project.local`
  files.
* Used `doCheckCross` instead of setting `doCheck` flag per package.

* nix: added profiling shell

```
nix develop .\#profiling
```

It will enter a nix shell with profiling environment for `ghc-9.8`.

* nix: build documentation, formats & shell only on `x86_64-linux`

* nix: removed nsh.sh script

* nix: removed shell.nix file

The only supported way to start one of the provides shells is by using
`nix develop`.

* nix: nix build .\#format.all

Added a convenient way to run all formatters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues / PRs related to CI nix This includes CI, nix changes or cabal dependencies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants