-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NoThunks to verify no memory leaks in PeerMetrics #4633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coot
commented
Jul 27, 2023
- ouroboros-network-framework: added NoThunk orphaned instances
- peer-metrics: use NoThunks in PeerMetrics
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
from
July 27, 2023 17:46
317ee05
to
3eed982
Compare
bolt12
approved these changes
Jul 28, 2023
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
from
July 28, 2023 20:05
3eed982
to
5979d62
Compare
Some test were failing because we also need to evaluate arguments of We should add |
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
6 times, most recently
from
August 2, 2023 14:57
3d29c1d
to
36a5aab
Compare
bolt12
reviewed
Aug 2, 2023
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
2 times, most recently
from
August 3, 2023 08:59
487db33
to
503d7b3
Compare
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
11 times, most recently
from
August 4, 2023 08:14
e7bd2c0
to
094e933
Compare
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
from
August 4, 2023 08:28
094e933
to
92a97f1
Compare
Use NoThunks library to verify that we don't have any unevaluated expressions in PeerMetric. This patch also makes PeerMetric more strict to satisfy the test. Apparently there was a small memory leak which goes away at every churn interval when we actually use peer metric in order to demote the 20% of worse performing peers.
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
2 times, most recently
from
August 4, 2023 11:16
1f74f81
to
2bff827
Compare
Also removed `asserts` flag from `network-mux.cabal`; and updated `cabal.project.local` files used in GHA.
The `continueWithState` and `continuewWithStateM` functions need `NOINLINE` pragma to make sure the `st` argument is evaluated to WHNF.
coot
force-pushed
the
coot/peer-metrics-nothunks
branch
from
August 4, 2023 14:39
2bff827
to
f2061c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.