Refactor PeerSelection.RootPeersDNS #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
added
networking
peer-sharing
coot
reviewed
Aug 9, 2023
ouroboros-network/src/Ouroboros/Network/PeerSelection/RootPeersDNS/DNS/LedgerPeers.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/RootPeersDNS/DNS/LedgerPeers.hs
Outdated
Show resolved
Hide resolved
bolt12
force-pushed
the
bolt12/4606
branch
2 times, most recently
from
9c5a794
to
ea2b5e2
Compare
coot
requested changes
Sep 20, 2023
ouroboros-network/sim-tests/Test/Ouroboros/Network/Diffusion/Node.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/sim-tests/Test/Ouroboros/Network/Diffusion/Node.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/RootPeersDNS/DNS/LocalRootPeers.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/RootPeersDNS/DNS/LocalRootPeers.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/RootPeersDNS/DNS/LedgerPeers.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerSelectionActions.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerSelectionActions.hs
Outdated
Show resolved
Hide resolved
bolt12
force-pushed
the
bolt12/4606
branch
2 times, most recently
from
c775c6f
to
af11b3b
Compare
coot
requested changes
Oct 4, 2023
ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/KnownPeers.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/KnownPeers.hs
Outdated
Show resolved
Hide resolved
coot
reviewed
Oct 10, 2023
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerStateActions.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerStateActions.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerStateActions.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/sim-tests/Test/Ouroboros/Network/PeerSelection/PeerGraph.hs
Outdated
Show resolved
Hide resolved
bolt12
force-pushed
the
bolt12/4606
branch
5 times, most recently
from
a4873f4
to
e0d61a9
Compare
coot
requested changes
Nov 9, 2023
ouroboros-network/sim-tests-lib/Test/Ouroboros/Network/LedgerPeers.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/PeerStateActions.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/Monitor.hs
Outdated
Show resolved
Hide resolved
- Refactor `withLedgerPeers` & `resolveDomainAccessPoint`
- Removes `withLedgerPeers` (only used in tests now)
- `withPeerSelectionActions` is responsible for fetching and resolving
all peers
- Renames `resolveDomainAccessPoint` to `resolveLedgerPeers`
- Splits `Ouroboros.Network.PeerSelection.RootPeersDNS` into
- `Ouroboros.Network.PeerSelection.DNS.RootPeers`
- `Ouroboros.Network.PeerSelection.DNS.LocalRoots`
- `Ouroboros.Network.PeerSelection.DNS.LedgerPeers`
- `Ouroboros.Network.PeerSelection.DNS.DNSSemaphore`
Add no assertion failure to testnet test suite Fix livelock test and peer seleection dodgy trace test
Also use targets from the right source of truth
bolt12
force-pushed
the
bolt12/4606
branch
3 times, most recently
from
7d0e692
to
fd160bf
Compare
bolt12
force-pushed
the
bolt12/4606
branch
3 times, most recently
from
bc2051c
to
5480712
Compare
coot
reviewed
Nov 15, 2023
ouroboros-network/sim-tests-lib/Test/Ouroboros/Network/PeerSelection.hs
Outdated
Show resolved
Hide resolved
ouroboros-network/src/Ouroboros/Network/PeerSelection/Governor/Types.hs
Outdated
Show resolved
Hide resolved
We are hiding the `peerconn` in an existential type, so we no longer need to map it `()`. This saves quite a lot of memory. This patch also removes the `Functor` instance of `PeerSelectionState`, which is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withLedgerPeers&resolveDomainAccessPointwithLedgerPeers(only used in tests now)withPeerSelectionActionsis responsible for fetching and resolving all peersresolveDomainAccessPointtoresolveLedgerPeersOuroboros.Network.PeerSelection.RootPeersDNSintoOuroboros.Network.PeerSelection.DNS.RootPeersOuroboros.Network.PeerSelection.DNS.LocalRootsOuroboros.Network.PeerSelection.DNS.LedgerPeersOuroboros.Network.PeerSelection.DNS.DNSSemaphoreCloses #4606