-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NotReleasedConnections in Server2 tests #4623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolt12
force-pushed
the
bolt12/4607
branch
2 times, most recently
from
July 12, 2023 15:08
31db120
to
5e6d2ba
Compare
This also fixes #4605 |
coot
reviewed
Aug 23, 2023
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
ouroboros-network-framework/test/Test/Ouroboros/Network/Server2.hs
Outdated
Show resolved
Hide resolved
bolt12
force-pushed
the
bolt12/4607
branch
2 times, most recently
from
September 1, 2023 14:40
5fe5bbf
to
a446e78
Compare
coot
reviewed
Sep 20, 2023
coot
reviewed
Sep 20, 2023
ouroboros-network-framework/sim-tests/Test/Ouroboros/Network/Server2/Sim.hs
Outdated
Show resolved
Hide resolved
bolt12
changed the title
Fix MultiNodeScript generator
Fix NotReleasedConnections in Server2 tests
Sep 29, 2023
coot
approved these changes
Oct 4, 2023
coot
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 12, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4607