Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DiffusionSimulation tracing #4622

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Refactor DiffusionSimulation tracing #4622

merged 4 commits into from
Sep 5, 2023

Conversation

bolt12
Copy link
Contributor

@bolt12 bolt12 commented Jul 11, 2023

Fixes #4610

@bolt12 bolt12 requested a review from coot as a code owner July 11, 2023 13:58
@bolt12 bolt12 added networking testing inbound-governor Issues / PRs related to inbound-governor labels Jul 11, 2023
@bolt12 bolt12 linked an issue Jul 11, 2023 that may be closed by this pull request
invalid transition in the inbound governor #4610
Closed
@coot coot force-pushed the coot/eclipse-evasion branch 4 times, most recently from 6a9f0a9 to 747d03d Compare August 7, 2023 13:13
Base automatically changed from coot/eclipse-evasion to master August 8, 2023 13:54
@coot
Copy link
Contributor

coot commented Aug 23, 2023

This PR needs to be updated.

@bolt12 bolt12 force-pushed the bolt12/coot/eclipse-evasion branch 2 times, most recently from f522c84 to 54fd34d Compare September 1, 2023 12:19
@bolt12
Fix invalid transition in the inbound governor tests
51e3d87 
Fix some tests that involve big ledger peers
@bolt12
Copy link
Contributor Author

bolt12 commented Sep 4, 2023

@coot done!

coot
coot approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor comment about the CHANGELOG.md file.

ouroboros-network/CHANGELOG.md Show resolved Hide resolved
@bolt12
Adds keyedTimeoutTruncated to Signal API
d466655 
This is useful for Testnet tests that are over an infinite signal and
might get truncated at the wrong time.
@bolt12
Update Changelog
0bb77ae
@bolt12 bolt12 added this pull request to the merge queue Sep 5, 2023
Merged via the queue into master with commit 5e4cec6 Sep 5, 2023
8 of 10 checks passed
@bolt12 bolt12 deleted the bolt12/coot/eclipse-evasion branch September 5, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coot coot coot approved these changes

@njd42 njd42 Awaiting requested review from njd42

@peterwthompson peterwthompson Awaiting requested review from peterwthompson

Assignees

@bolt12 bolt12

Labels
inbound-governor Issues / PRs related to inbound-governor testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid transition in the inbound governor
2 participants
@bolt12 @coot