Update q-s-m to allow bracketing #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsko
approved these changes
Mar 3, 2020
| -- TODO label tags | ||
| prettyCommands smUnused hist prop | ||
| where | ||
| test :: QSM.Commands (At Cmd Blk IO) (At Resp Blk IO) | ||
| -> QC.PropertyM IO | ||
| -> IO |
The new `runCommands'` command no longer lives in `PropertyM`, which means we can finally do proper bracketing. We don't use each bracketed function where possible, as in some cases we do some manual closing and reopening.
Use the infrastructure we wrote that has since been integrated in q-s-m.
Use the infrastructure we wrote that has since been integrated in q-s-m.
Use the infrastructure we wrote that has since been integrated in q-s-m.
Use the infrastructure we wrote that has since been integrated in q-s-m.
Use the infrastructure we wrote that has since been integrated in q-s-m.
It has become part of quickcheck-state-machine.
mrBliss
force-pushed
the
mrBliss/update-q-s-m
branch
from
6bf3001
to
22c8838
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jun 9, 2020
2228: Fix broken q-s-m tests and all bugs that appeared r=mrBliss a=mrBliss In #1739, I made some changes as some of our q-s-m infrastructure had been adopted by quickcheck-state-machines. Unfortunately, because of confusion with different types adopted in quickcheck-state-machines than the ones we use, our postconditions started checking the result of the implementation with the result of the *implementation* instead of the result of the model 🤦. Revert the changes that led to this and fix all bugs there were hidden because of it. Co-authored-by: Thomas Winant <[email protected]>
coot
pushed a commit
that referenced
this pull request
May 16, 2022
2228: Fix broken q-s-m tests and all bugs that appeared r=mrBliss a=mrBliss In #1739, I made some changes as some of our q-s-m infrastructure had been adopted by quickcheck-state-machines. Unfortunately, because of confusion with different types adopted in quickcheck-state-machines than the ones we use, our postconditions started checking the result of the implementation with the result of the *implementation* instead of the result of the model 🤦. Revert the changes that led to this and fix all bugs there were hidden because of it. Co-authored-by: Thomas Winant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1715
Update dependency on quickcheck-state-machine
Use
runCommands'in*.StateMachineThe new
runCommands'command no longer lives inPropertyM, which means we can finally do proper bracketing.We don't use each bracketed function where possible, as in some cases we do some manual closing and reopening.