Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid PropertyM in tests #1715

Closed
edsko opened this issue Feb 27, 2020 · 1 comment · Fixed by #1739
Closed

Avoid PropertyM in tests #1715

edsko opened this issue Feb 27, 2020 · 1 comment · Fixed by #1739
Assignees
@mrBliss
Labels
consensus issues related to ouroboros-consensus testing
Milestone
S8 2020-03-12

Comments

@edsko
Copy link
Contributor

edsko commented Feb 27, 2020

So that we can use bracket and bracket-like functions. This will require an upstream patch; I've already submitted one at advancedtelematic/quickcheck-state-machine#358 but it needs some adjustment.
@edsko
Copy link
Contributor Author

edsko commented Feb 27, 2020

Should use this to solve the TODO at 6996372#diff-c9986e06542d8ae365d50efc2dffd264R1308 .

@edsko edsko added consensus issues related to ouroboros-consensus testing labels Feb 27, 2020
@IntersectMBO IntersectMBO deleted a comment from edsko Feb 27, 2020
@edsko edsko added this to the S8 2020-03-12 milestone Feb 27, 2020
@mrBliss mrBliss self-assigned this Mar 3, 2020
@mrBliss mrBliss mentioned this issue Mar 3, 2020
Merged
@iohk-bors iohk-bors bot closed this as completed in 5a9677f Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrBliss mrBliss

Labels
consensus issues related to ouroboros-consensus testing
Projects
None yet
Milestone
S8 2020-03-12
Development

Successfully merging a pull request may close this issue.

Update q-s-m to allow bracketing IntersectMBO/ouroboros-network
2 participants
@mrBliss @edsko