fix(910B): fix bugs in 910B for varlen and fixlen FA #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li126com
changed the title
li126com
changed the title
|
补充PR的description |
sunpengsdu
reviewed
Aug 28, 2024
| @@ -309,13 +309,14 @@ def _forward_step( | |||
| output_obj = loss_reduced | |||
|
|
|||
| moe_loss = ( | |||
| sum(moe_losses) * gpc.config.loss.moe_loss_coeff | |||
| sum(moe_losses) * gpc.config.loss.moe_loss_coeff # pylint: disable=E0606 | |||
There was a problem hiding this comment.
这个有点怪就是在910B上执行pre-commit检查他会在这行出这个问题，只好disable了
sunpengsdu
reviewed
Aug 28, 2024
| # reformat cos/sin shape. | ||
| cos = torch.cat((cos, cos), dim=-1)[None, :, None, :] | ||
| sin = torch.cat((sin, sin), dim=-1)[None, :, None, :] | ||
|
|
||
| if len(x.shape) == 5: | ||
| q, k, _ = x.unbind(dim=2) | ||
|
|
||
| q, k = q.squeeze(dim=2), k.squeeze(dim=2) |
There was a problem hiding this comment.
这不是在https://github.com/InternLM/InternEvo/pull/296/files 去掉了吗，为啥这里又改回来
There was a problem hiding this comment.
没有，这个是我们当时说的他不是有个漏加的地方么，就是296的PR去掉了attention那块的squeeze，当时不是说embedding这应该加一个squeeze再
Closed
done |
sunpengsdu
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
issue 307
Modification
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: