Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support newest internevo with deeplink #280

Merged

Conversation

POI-WX
Copy link
Collaborator

@POI-WX POI-WX commented Jul 18, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  • Support newest internevo with deeplink.
  • Support the inplace version of rotary embedding and fused adamw.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@jingguo-st jingguo-st force-pushed the wx/support_newest_internevo_with_deeplink branch from 124fec4 to 0dd12c0 Compare September 11, 2024 08:30
@jingguo-st jingguo-st force-pushed the wx/support_newest_internevo_with_deeplink branch from 0dd12c0 to 063781e Compare September 11, 2024 08:33
…wx/support_newest_internevo_with_deeplink
@POI-WX POI-WX changed the title fix(dipu): support newest internevo with deeplink fix: support newest internevo with deeplink Sep 19, 2024
@sunpengsdu sunpengsdu merged commit 3c65623 into InternLM:develop Sep 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants