Skip to content

Commit

Permalink
fix pylint
Browse files Browse the repository at this point in the history
  • Loading branch information
zigzagcai committed Sep 11, 2024
1 parent 8f02a5a commit 0b68018
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions internlm/data/build_dataloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def get_megatron_train_loader_items(data_cfg):
from internlm.data.megatron import helpers # noqa # pylint: disable=W0611
except ImportError:
if gpc.is_rank_for_log():
subprocess.run(
subprocess.run( # noqa # pylint: disable=W1510
[
"g++",
"-O3",
Expand Down Expand Up @@ -247,7 +247,12 @@ def build_valid_loader_with_data_type():
data_cfg = gpc.config.data

# TODO: For validation, currenlt we only support dummy dataset for streaming/megatron/mock DataType.
if data_cfg.type in [DataType.tokenized.name, DataType.streaming.name, DataType.megatron.name, DataType.mocked.name]:
if data_cfg.type in [
DataType.tokenized.name,
DataType.streaming.name,
DataType.megatron.name,
DataType.mocked.name,
]:
valid_ds, valid_collate_fn = get_tokenized_valid_loader_items(data_cfg)
else:
raise ValueError(f"dataset type {data_cfg.type} is not supported")
Expand Down

0 comments on commit 0b68018

Please sign in to comment.