Reduce lock contention caused by regen pattern #3046
+64
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
SingleThreadQueueExtent#getFullBlock
callsSingleThreadQueueExtent#getOrCreateChunk
every time. As this method contains a lock, that can cause some significant contention. If we process an edit chunk-wise, we can remember the chunk instead and have a cheaper access pattern. In my tests I'm seeing a ~15% improvement in edit duration.Submitter Checklist