Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lock contention caused by regen pattern #3046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SirYwell
Copy link
Member

Overview

Description

SingleThreadQueueExtent#getFullBlock calls SingleThreadQueueExtent#getOrCreateChunk every time. As this method contains a lock, that can cause some significant contention. If we process an edit chunk-wise, we can remember the chunk instead and have a cheaper access pattern. In my tests I'm seeing a ~15% improvement in edit duration.

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner December 26, 2024 08:49
@dordsor21 dordsor21 requested a review from a team December 26, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants