fix: correctly save block orientations in structure schematics #3033
+219
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
reviewed
Dec 18, 2024
.../main/java/com/fastasyncworldedit/core/extent/clipboard/io/schematic/MinecraftStructure.java
Show resolved
Hide resolved
SirYwell
approved these changes
Dec 18, 2024
NotMyFault
approved these changes
Dec 22, 2024
dordsor21
reviewed
Dec 24, 2024
| write(clipboard, "FAWE"); | ||
| } | ||
|
|
||
| public void write(Clipboard clipboard, String owner) throws IOException { |
There was a problem hiding this comment.
Is there a particular reason for removing owner? We should also have it as a deprecated method still to ensure API compatibility
There was a problem hiding this comment.
author: Name of the player who created this structure. Only exists for structures saved before 1.13.
https://minecraft.wiki/w/Structure_file
Will add method again and delegate to write(Clipboard)
dordsor21
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3028
Description
Submitter Checklist