rename: don't leave trailing commas #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a TODO
When renaming the last element of a `from a import b,c` import, don't leave the trailing comma after `b`
facebook-github-bot
added
the
CLA Signed
zsol
added a commit
that referenced
this pull request
Dec 2, 2024
#1254 was a bit too aggressive in removing commas. They shouldn't be removed if there are parenthesis around the imported names.
zsol
added a commit
that referenced
this pull request
Dec 2, 2024
#1254 was a bit too aggressive in removing commas. They shouldn't be removed if there are parenthesis around the imported names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename: don't leave trailing commas
When renaming the last element of a
from a import b,cimport, don't leave the trailing comma afterbStack created with Sapling. Best reviewed with ReviewStack.