Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow scheduled_removals to accept a tuple #1253

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 22 additions & 12 deletions libcst/codemod/commands/rename.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,15 +103,20 @@ def as_name(self, value: Optional[Tuple[str, str]]) -> None:
self.context.scratch["as_name"] = value

@property
def scheduled_removals(self) -> Set[cst.CSTNode]:
def scheduled_removals(
self,
) -> Set[Union[cst.CSTNode, Tuple[str, Optional[str], Optional[str]]]]:
"""A set of nodes that have been renamed to help with the cleanup of now potentially unused
imports, during import cleanup in `leave_Module`."""
imports, during import cleanup in `leave_Module`. Can also contain tuples that can be passed
directly to RemoveImportsVisitor.remove_unused_import()."""
if "scheduled_removals" not in self.context.scratch:
self.context.scratch["scheduled_removals"] = set()
return self.context.scratch["scheduled_removals"]

@scheduled_removals.setter
def scheduled_removals(self, value: Set[cst.CSTNode]) -> None:
def scheduled_removals(
self, value: Set[Union[cst.CSTNode, Tuple[str, Optional[str], Optional[str]]]]
) -> None:
self.context.scratch["scheduled_removals"] = value

@property
Expand Down Expand Up @@ -169,11 +174,13 @@ def leave_Import(
and import_alias.asname is not None
):
self.bypass_import = True
# TODO: put this into self.scheduled_removals
RemoveImportsVisitor.remove_unused_import(
self.context,
import_alias.evaluated_name,
asname=import_alias.evaluated_alias,
# Add removal tuple instead of calling directly
self.scheduled_removals.add(
(
import_alias.evaluated_name,
None,
import_alias.evaluated_alias,
)
)
new_names.append(import_alias.with_changes(asname=None))

Expand Down Expand Up @@ -307,10 +314,13 @@ def leave_Attribute(
def leave_Module(
self, original_node: cst.Module, updated_node: cst.Module
) -> cst.Module:
for removal_node in self.scheduled_removals:
RemoveImportsVisitor.remove_unused_import_by_node(
self.context, removal_node
)
for removal in self.scheduled_removals:
if isinstance(removal, tuple):
RemoveImportsVisitor.remove_unused_import(
self.context, removal[0], removal[1], removal[2]
)
else:
RemoveImportsVisitor.remove_unused_import_by_node(self.context, removal)
# If bypass_import is False, we know that no import statements were directly renamed, and the fact
# that we have any `self.scheduled_removals` tells us we encountered a matching `old_name` in the code.
if not self.bypass_import and self.scheduled_removals:
Expand Down
Loading