Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't allow no space no parentheses after
if
.Summary
There should be a validation for
If
node similar to others such asWhile
orAssert
to not allow generating incorrect code.There is even a TODO left for that reason.
Let me know if there should be other validations for
If
.Test Plan
Before:
With the current version of LibCST it is possible to generate the code like this with an
If
node followed byName('x')
without space:which isn't correct Syntax.
The new test fails:
After:
Attempting to generate incorrect code raises an exception preventing it:
The new test passes: