Update iOS deployment target to silence Xcode 15 warnings #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 15 doesn't support deploying to older versions and shows a warning on every build
- BuildFile header reference no longer exists - IGListSingleSelectionControllerTests.m was in compile sources twice
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@TimOliver merged this pull request in 7256bfb. |
GreeMoz
pushed a commit
to appintheair/IGListKit
that referenced
this pull request
Jan 31, 2024
…1589) Summary: ## Changes in this pull request Xcode 15 has moved the iOS deployment target up to iOS 12 (just like Instagram#1573 for Xcode 14). I did not modify the changelog because there's already an entry there for iOS 11 and macOS 10.13. This also includes a build error fix for IGWarnAssert (dffcd4d). I tried running the unit tests but a number of them are failing from previous changes. ### Checklist - [ ] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1589 Reviewed By: fabiomassimo Differential Revision: D50013207 Pulled By: TimOliver fbshipit-source-id: 6c7a7b2ca3dd1265f11e85979432eded3292ed06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Xcode 15 has moved the iOS deployment target up to iOS 12 (just like #1573 for Xcode 14). I did not modify the changelog because there's already an entry there for iOS 11 and macOS 10.13.
This also includes a build error fix for IGWarnAssert (dffcd4d). I tried running the unit tests but a number of them are failing from previous changes.
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.