Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add More Metrics to be Logged by LoggerHook #475

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Add More Metrics to be Logged by LoggerHook #475

merged 6 commits into from
Aug 2, 2024

Conversation

surge119
Copy link
Contributor

Summary

Added the following metrics:

  • Violation Count per Rule per File
  • Violation Count per Rule per File with Autofixes
  • Total Violation Count per File

Test Plan

make

@surge119 surge119 requested review from amyreese and zsol as code owners July 30, 2024 23:04
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2024
amyreese
amyreese reviewed Aug 2, 2024
View reviewed changes
src/fixit/engine.py Outdated Show resolved Hide resolved
@amyreese amyreese merged commit e4d9bbd into Instagram:main Aug 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyreese amyreese amyreese approved these changes

@zsol zsol Awaiting requested review from zsol zsol is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surge119 @amyreese @facebook-github-bot