Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lintrule collections abc #460

Merged
merged 18 commits into from
Jun 5, 2024
Merged

Conversation

surge119
Copy link
Contributor

@surge119 surge119 commented May 31, 2024

Summary

Since python 3.3, the Collections Abstract Base Classes (ABC) has been moved to the collections.abc module. This lint rule checks and fixes (some) ABC imports from collections to collections.abc.

Test Plan

The lint rule has several built in tests that were run using hatch run test

@surge119 surge119 requested review from amyreese and zsol as code owners May 31, 2024 21:34
@facebook-github-bot
Copy link

Hi @surge119!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2024
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

src/fixit/rules/deprecated_abc_import.py Outdated Show resolved Hide resolved
src/fixit/rules/deprecated_abc_import.py Show resolved Hide resolved
src/fixit/rules/deprecated_abc_import.py Outdated Show resolved Hide resolved
@surge119 surge119 requested a review from amyreese June 5, 2024 17:25
@amyreese amyreese merged commit 4cd8a6e into Instagram:main Jun 5, 2024
16 checks passed
@amyreese
Copy link
Member

amyreese commented Jun 5, 2024

Thank you! 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants