Support lint ignore directives in more places #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
amyreese
added a commit
that referenced
this pull request
Apr 20, 2024
Adds logic to `LintRule.node_comments()` looking for directives in more locations relative to the current node: - trailing inline comments after commas - preceding and trailing comments inside brackets - preceding comments before/after decorators for classes and functions In addition, to better support suppressions for decorators themselves, the logic to break upward searching until reaching a `leading_lines` node has been modified to exclude `Decorator` nodes which have their own leading lines that aren't used for the first decorator on a class. Based on code examples reported in #413 ghstack-source-id: 4907870d9ecde15fd1110b3d276bc7f95569c513 Pull Request resolved: #441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adds logic to
LintRule.node_comments()looking for directives in morelocations relative to the current node:
In addition, to better support suppressions for decorators themselves,
the logic to break upward searching until reaching a
leading_linesnode has been modified to exclude
Decoratornodes which have their ownleading lines that aren't used for the first decorator on a class.
Based on code examples reported in #413