Make CollectionError pickleable #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectionError could not be unpickled because the default `Exception.__reduce__` implementation does not include any attributes/values that weren't passed to the superclass constructor, resulting in a failure when unpickling the exception in the parent class because the `rule` argument wasn't given. This updates the class to add a custom `__reduce__` that fixes the ability to pickle/unpickle the class correctly, fixing the primary issue with exceptions during linting resulting in broken process pools. Fix #381 [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
amyreese
added a commit
that referenced
this pull request
Oct 24, 2023
CollectionError could not be unpickled because the default `Exception.__reduce__` implementation does not include any attributes/values that weren't passed to the superclass constructor, resulting in a failure when unpickling the exception in the parent class because the `rule` argument wasn't given. This updates the class to add a custom `__reduce__` that fixes the ability to pickle/unpickle the class correctly, fixing the primary issue with exceptions during linting resulting in broken process pools. Fix #381 ghstack-source-id: d8bd29c52d8320ee33a7f43937df6dc4e883d90d Pull Request resolved: #401
amyreese
added a commit
that referenced
this pull request
Oct 24, 2023
CollectionError could not be unpickled because the default `Exception.__reduce__` implementation does not include any attributes/values that weren't passed to the superclass constructor, resulting in a failure when unpickling the exception in the parent class because the `rule` argument wasn't given. This updates the class to add a custom `__reduce__` that fixes the ability to pickle/unpickle the class correctly, fixing the primary issue with exceptions during linting resulting in broken process pools. Fix #381 ghstack-source-id: d8bd29c52d8320ee33a7f43937df6dc4e883d90d Pull Request resolved: #401
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
CollectionError could not be unpickled because the default
Exception.__reduce__implementation does not include anyattributes/values that weren't passed to the superclass constructor,
resulting in a failure when unpickling the exception in the parent
class because the
ruleargument wasn't given.This updates the class to add a custom
__reduce__that fixes theability to pickle/unpickle the class correctly, fixing the primary
issue with exceptions during linting resulting in broken process
pools.
Fix #381