fix(compare_singleton_primitives_by_is): compare Name directly instead of QualifiedName #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
…d of QualifiedName fixes Instagram#378 and Instagram#375 which are caused by Instagram/LibCST#389. Qualifying a name will never make some thing that wasn't already True/False/None into a True/False/None: ```python import libcst as cst from libcst.metadata.name_provider import QualifiedNameProvider from textwrap import dedent wrapper = cst.MetadataWrapper( cst.parse_module(dedent( ''' x = None x() ''' )) ) x_ref = wrapper.module.body[1].body[0].value print(wrapper.resolve(QualifiedNameProvider)[x_ref]()) ``` prints: ```python {QualifiedName(name='x', source=<QualifiedNameSource.LOCAL: 3>)} ``` Co-authored-by: Amethyst Reese <[email protected]>
amyreese
force-pushed
the
fix/primitive_is
branch
from
acf37ec to
bfa7741
Compare
|
Thank you! I modified the fix slightly, so that it still checks for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #378 and #375 which are caused by Instagram/LibCST#389.
Qualifying a name will never make something that wasn't already True/False/None into a True/False/None, so it's not necessary.
Test Plan
Added two Valid cases, one of which breaks on HEAD^.