Add groupwise registration class #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoked from Python, it causes: swig/python detected a memory leak of type 'itkImageUC2_Pointer *', no destructor found.
include/itkANTsGroupwiseRegistration.h:136:3: error: 'DataObjectPointer' does not name a type; did you mean 'DataObjectIterator'?
Using just affine transforms cannot get us to the perfect result.
The baseline was generated by running: python templateCommandSyN.py with https://github.com/ntustison/TemplateBuildingExample/blob/bd274dd1a0e07759b732be9842b7922e24a3f23b/BrainSlices/templateCommandSyN.py
This changes the procedural interface name from itk.an_ts_groupwise_registration() into itk.ants_groupwise_registration()
The original code was unintentionally reducing intensity contribution of images with lower list indices by repeatedly weighting them by (1-w), where w is per image weight (usually 1/N, e.g. 0.1 for 10 input images).
Build error from CI, which sets `ITK_WRAP_IMAGE_DIMS` to `2;3;4`:
itkANTSGroupwiseRegistrationPython.cpp
D:\a\im\build\cp38-cp38-win_amd64\_deps\ants_inner-src\Utilities\itkAverageAffineTransformFunction.h(184,32): error C2027: use of undefined type 'itk::AverageAffineTransformFunctionHelperNameSpace::HelperType<itk::AverageAffineTransformFunctionHelperNameSpace::Dispatcher<4>,float>' [D:\a\im\build\cp38-cp38-win_amd64\Wrapping\Modules\ANTsWasm\ANTsWasmPython.vcxproj]
(compiling source file 'itkANTSGroupwiseRegistrationPython.cpp')
D:\a\im\build\cp38-cp38-win_amd64\_deps\ants_inner-src\Utilities\itkAverageAffineTransformFunction.h(59,7):
see declaration of 'itk::AverageAffineTransformFunctionHelperNameSpace::HelperType<itk::AverageAffineTransformFunctionHelperNameSpace::Dispatcher<4>,float>'
D:\a\im\build\cp38-cp38-win_amd64\_deps\ants_inner-src\Utilities\itkAverageAffineTransformFunction.h(184,32):
the template instantiation context (the oldest one first) is
C:\P\IPP\ITK-win_38-x64\Wrapping\Typedefs\itkANTSGroupwiseRegistrationSwigInterface.h(61,145):
see reference to class template instantiation 'itk::ANTSGroupwiseRegistration<itk::Image<short,4>,itk::Image<float,4>,float>' being compiled
D:\a\im\include\itkANTSGroupwiseRegistration.hxx(303,1):
while compiling class template member function 'void itk::ANTSGroupwiseRegistration<itk::Image<short,4>,itk::Image<float,4>,float>::GenerateData(void)'
D:\a\im\include\itkANTSGroupwiseRegistration.hxx(428,18):
see reference to class template instantiation 'itk::AverageAffineTransformFunction<itk::ANTSGroupwiseRegistration<itk::Image<short,4>,itk::Image<float,4>,float>::GenerateData::AffineType>' being compiled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds group-wise registration class, along with Python wrapping, unit tests, and unit test data.