Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculateScore function #704

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bn-d
Copy link

@bn-d bn-d commented Jul 11, 2024

The bug is accidentally introduced in #341 . It incorrectly applied the parenthesis to the function changing (1 + x / y) to ((1 + x) / y).

Copy link

welcome bot commented Jul 11, 2024

Thank You Banner

💖 Thanks for opening this pull request! 💖 The InnerSource Commons community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines.

If you are submitting a new pattern, the following things will help get your pull request across the finish line! 🏁

  • Confirm that you have used our pattern template. Please remove any placeholder text and sections that your pattern did not need.
  • We run a number of automated checks on your PR. Please review the output of those checks on the PR itself, and see if any issues got flagged that you can fix yourself.
  • Make sure you have added your new pattern to the list of patterns in the main README.md. If you are unsure where to add your pattern, just let us know by commenting on your PR and we will help you.

This project has a small number of maintainers, volunteering their time to this project. So please be patient and we will get back to you as soon as we can. If we don't acknowledge this pull request after 7 days, feel free to chat to us about it in our Slack workspace.

@spier
Copy link
Member

spier commented Jul 12, 2024

Thank you for this contribution @bn-d!

@Michadelic could you help us with a review on this PR?

@spier spier added 📖 Type - Content Work Working on contents is the main focus of this issue / PR 🪲 Bug Bug - something that seems to be broken labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 Bug Bug - something that seems to be broken 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants