Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python xmlsec library support #961

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AndrewFoxUUID
Copy link

Description

The feature or problem addressed by this PR
What your changes do and why you chose this solution

Checklist

  • Checked that no other issues or pull requests exist for the same issue/change
  • Added tests covering the new functionality
  • Updated documentation OR the change is too minor to be documented
  • Updated CHANGELOG.md OR changes are insignificant

@c00kiemon5ter
Copy link
Member

Hello and thank you for this contribution. I'd like to suggest to make the changes on their own class as a new crypto backend, to keep the new functionality clean.
Or, is the intention to use XMLSecurity and the xmlsec module along side each other?

@AndrewFoxUUID
Copy link
Author

Hello and thank you for this contribution. I'd like to suggest to make the changes on their own class as a new crypto backend, to keep the new functionality clean. Or, is the intention to use XMLSecurity and the xmlsec module along side each other?

My understanding of the current codebase is that the XmlSecurityBackend is already using xmlsec, it just hasn't been updated to use xmlsec's newest functionalities, and isn't nearly as developed as the XmlSec1 backend. The main purpose of these changes is to use xmlsec instead of creating a terminal flow to execute a libxmlsec1 call for better efficiency.

@AndrewFoxUUID AndrewFoxUUID marked this pull request as draft May 14, 2024 16:29
@AndrewFoxUUID AndrewFoxUUID marked this pull request as ready for review May 14, 2024 18:50
@af-splashtop-test
Copy link

@c00kiemon5ter 654151 Can you please review these changes?

@johanlundberg johanlundberg mentioned this pull request Jun 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants