Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination value MUST be present in Response if binding is HTTP-REDIRECT or HTTP-POST #812

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Destination value MUST be present in Response if binding is HTTP-REDIRECT or HTTP-POST #812

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6841de6
fix: Destination value MUST be present in Response if binding is HTTP…
peppelinux Jul 20, 2021
1476eb9
chore: destination check in response, code cleanup
peppelinux Jul 22, 2021
a63d382
Merge branch 'master' into destination
peppelinux Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/saml2/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,11 +409,17 @@ def _verify(self):
raise RequestVersionTooHigh()

if self.asynchop:
if (
self.response.destination
and self.response.destination not in self.return_addrs
if not (
getattr(self.response, 'destination')
peppelinux marked this conversation as resolved.
Show resolved Hide resolved
):
logger.error("%s not in %s", self.response.destination, self.return_addrs)
logger.error(
f"Invalid response destination in asynchop"
peppelinux marked this conversation as resolved.
Show resolved Hide resolved
)
return None
elif self.response.destination not in self.return_addrs:
logger.error(
f"{self.response.destination} not in {self.return_addrs}"
)
return None

valid = self.issue_instant_ok() and self.status_ok()
Expand Down