Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust Info metadata in JSON blob in entity attribute #271

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

enriquepablo
Copy link
Contributor

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

Copy link
Contributor

@mikaelfrykholm mikaelfrykholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested with some hacked up metadata.

@alexstuart
Copy link

Hi @enriquepablo , the REFEDS Working Group hasn't finalised the specification of entity attribute yet, so it might be premature to code http://refeds.org/entity-selection-profile in. When are you looking to land this change?

@enriquepablo
Copy link
Contributor Author

We were going to put this into staging as soon as it was merged and released. The idea is to 1st check that it does not break the current workflow, and then deploy the mdq service that knows how to use the new data produced by pyff, and then deploy the discovery service that knows how to use the new mdq service (all should be backwards compatible). So to reach production it's still some time.

@enriquepablo
Copy link
Contributor Author

(Sorry I sent the prev message too soon)
To be safer, I can put aside the add pipe to extract trustinfo from entity attribute commit aside in another branch until the specification is finalized.

@leifj
Copy link
Contributor

leifj commented Sep 30, 2024

are we ready to merge this?

@enriquepablo
Copy link
Contributor Author

Yes. If the working group ends up with a different specification, we will do a later update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants