Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an EntraID OIDC backend based on the included OpenIDConnectBackend #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ceko
Copy link

@ceko ceko commented Apr 8, 2024

EntraID OIDC Backend

We have a need to use EntraID as an authentication backend, but EntraID does not closely follow the OpenID spec and can't be integrated with the current backends. In particular, the issuer used in discovery does not always match the issuer returned in other parts of the login flow.

I built a backend using the OpenIDConnectBackend as a model and integrated with the msal library. I also wrote several tests using the same backend's tests as a model for coverage.

Please let me know if this is something you'd like to include in the base product, if not I'll continue using it as a module in my SATOSA instance.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

@c00kiemon5ter
Copy link
Member

Thank you for this work @ceko and thank for making the dependencies optional.

I think that we can pull this in. If we need to make changes and to maintain this module, would you want to be contacted to take care of this?

@ceko
Copy link
Author

ceko commented Apr 24, 2024

I don't need to be contacted, but I wouldn't mind being marked as a maintainer for this backend. Would this change make it into the Docker image as well? We are currently using the image for an upcoming project, I'd like to prepare for having/not having the msal library.

@ceko
Copy link
Author

ceko commented Apr 24, 2024

Also, @c00kiemon5ter, I'm doing this on behalf of Rochester Institute of Technology. Please let me know if you'd like anything from me to advertise that relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants