Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSRF Hosts in Livecycle container #34

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

nishant-nayak
Copy link
Member

Description

Small error in CSRF hosts configuration prevents Livecycle builds from completing. Fixed here.

Dependencies

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Tested with local Docker build

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nishant-nayak nishant-nayak added the bug Something isn't working label Sep 24, 2023
@nishant-nayak nishant-nayak added this to the v0.1 milestone Sep 24, 2023
@nishant-nayak nishant-nayak self-assigned this Sep 24, 2023
@render
Copy link

render bot commented Sep 24, 2023

@livecycle
Copy link

livecycle bot commented Sep 24, 2023

ieee-nitk

Your Livecycle playground is ready 🎉.

Playground version up to date (6659fc6)

Invite team members and start collaborating 💪

Check the box and click "invite" to invite collaborators

  • Nishant Nayak
  • Anirudh Prabhakaran

invite

Click here to invite the rest of your team.

@IEEE-NITK IEEE-NITK deleted a comment from render bot Sep 24, 2023
@nishant-nayak nishant-nayak marked this pull request as draft September 24, 2023 09:08
@nishant-nayak nishant-nayak marked this pull request as ready for review September 24, 2023 09:17
@anirudhprabhakaran3 anirudhprabhakaran3 merged commit 20448f6 into main Sep 25, 2023
2 checks passed
@anirudhprabhakaran3 anirudhprabhakaran3 deleted the fix-csrf-hosts branch September 25, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants