Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift to Svelte and DRF #12

Merged
merged 15 commits into from
Jul 29, 2023
Merged

Shift to Svelte and DRF #12

merged 15 commits into from
Jul 29, 2023

Conversation

anirudhprabhakaran3
Copy link
Member

@anirudhprabhakaran3 anirudhprabhakaran3 commented Jul 5, 2023

Description

Move to app based on Django REST Framework and SvelteKit

Dependencies

Umm...nearly everything is changing lmaoo

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nishant-nayak nishant-nayak self-requested a review July 6, 2023 04:20
@nishant-nayak
Copy link
Member

Can you additionally attach a volume to the frontend as well? As discussed, let's have Docker be the primary supported method of development.

@nishant-nayak
Copy link
Member

Couple of things to add/fix:

  • Issue of volume not mounting properly on Windows. When files are changed on the host, the changes are reflected in the container but Vite does not seem to reload the SvelteKit application.
  • Adding Storybook support to the SvelteKit application.

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty big changes, thanks for working on making the development experience seamless! RIP Windows purists xD

@nishant-nayak nishant-nayak merged commit 05a9f07 into main Jul 29, 2023
1 check passed
@nishant-nayak nishant-nayak deleted the move_svelete_and_drf branch July 29, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants